Forms: keep Form Responses admin bar link visible on mobile by dhasilva · Pull Request #50421 · Automattic/jetpack

dhasilva · 2026-07-10T19:03:21Z

Fixes DSGCOM-595

Proposed changes

The "Form Responses" quick link that Jetpack Forms adds to the admin bar on singular pages containing a form was disappearing on mobile viewports (≤782px). WordPress core's admin-bar.css hides every top-level admin bar item below 782px and only re-shows a hardcoded allowlist of core node IDs; the custom jetpack-forms node was never on that list.
Emit a small, scoped <style> alongside the node that re-shows #wp-admin-bar-jetpack-forms on mobile. The selector carries two IDs, so it beats core's single-ID hiding rule on specificity (no !important needed for the un-hide).
Size the icon to match the native mobile items: the anchor becomes a 52px-wide flex box centering a 28px SVG glyph, mirroring core's 52×46 icon boxes. The .ab-icon overrides use !important because the SVG carries its desktop sizing in an inline style attribute, which otherwise wins the cascade.
Desktop rendering (icon + "Form Responses" label) is unchanged — everything lives inside @media (max-width: 782px).

Related product discussion/links

https://linear.app/a8c/issue/DSGCOM-595

Does this pull request change what data or activity we track or use?

No.

Testing instructions

On a site with Jetpack (or the standalone Jetpack Forms plugin) active, publish a page/post that contains a Jetpack Form and includes a form block, and make sure you're logged in as a user who can edit_pages.
View that page on the front end at a desktop width (>782px). Confirm the admin bar shows the "Form Responses" item with its icon and text label, as before.
Narrow the browser to a mobile width (≤782px), e.g. 430px, and reload.
- Before: the Form Responses item is absent from the admin bar.
- After: the Form Responses icon appears in the admin bar, the same size and vertical alignment as the native icons (Edit, New, Comments, etc.), with the text label hidden like the native items.
Tapping the icon still opens the Form Responses (Feedback) dashboard.

WordPress core hides all non-allowlisted top-level admin bar items below 782px, dropping the custom jetpack-forms quick link. Re-show it and size the icon to match the native mobile items (52px box, centered 28px glyph). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

github-actions · 2026-07-10T19:04:57Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/dsgcom-595-form-responses-masterbar-mobile branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/dsgcom-595-form-responses-masterbar-mobile

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-07-10T19:06:47Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2026-07-10T19:14:06Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form.php	1017/1579 (64.41%)	-0.37%	9 💔

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

CGastrell · 2026-07-10T20:15:11Z

Works nicely! Maybe tweak the icon a bit so it blends better with the others on mobile? Font color on those is rgba(240, 246, 252, 0.6)

The Form Responses SVG fills with currentColor. Core dims its own mobile admin bar icons to rgba(240,246,252,0.6) via selectors keyed to core node IDs, which never match our custom node, so ours rendered brighter and stood out. Set the same color on our item inside the existing mobile media query. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

dhasilva · 2026-07-13T19:08:56Z

Done — set color: rgba(240, 246, 252, 0.6) on the item inside the mobile media query. The SVG fills with currentColor, so it now matches the dimmed color core applies to its own mobile admin bar items (49a11de).

Generated by Claude.

The icon SVG fills with currentColor and inherited the item's full-brightness text color (#f0f0f1), so it rendered brighter than the native admin bar icons on desktop too -- core dims those to rgba(240,246,252,0.6) at every width, not only on mobile. Verified live: our icon computed to rgb(240,240,241) vs the native rgba(240,246,252,0.6). Fade the icon to 0.6 opacity to match, and restore full opacity on hover/focus. Using opacity rather than a hardcoded color keeps the hover state tracking the user's admin color scheme accent, as the native icons do. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

dhasilva · 2026-07-13T19:17:53Z

Follow-up: turned out the icon was also brighter than the native ones on desktop, not just mobile — core dims its icons to rgba(240,246,252,0.6) at every width, and our SVG (fill: currentColor) was inheriting the item's full-brightness text color instead. Verified live: ours computed to rgb(240,240,241) vs native rgba(240,246,252,0.6).

Reworked it to fade the icon to opacity: 0.6 at all widths and restore full opacity on hover/focus. Using opacity instead of a hardcoded color keeps the hover state tracking the user's admin color scheme accent, like the native icons do (ffeeb59). Confirmed the icon now blends with its neighbors on both desktop and mobile.

Generated by Claude.

The opacity:0.6 fix compounded on mobile: at <=782px core already dims the item's text color to rgba(240,246,252,0.6), which the SVG inherits via currentColor, so applying opacity:0.6 on top made it ~0.36 -- visibly dimmer than the native icons. Reset opacity to 1 inside the mobile block; the desktop fade still applies where core only dims its ::before glyphs. Verified live at both breakpoints: icon now computes to an effective rgba(240,246,252,0.6) and blends with its neighbors on mobile and desktop. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

dhasilva · 2026-07-13T19:24:28Z

Correction to my note above: the opacity change actually double-dimmed the icon on mobile. At ≤782px core already dims the item's text color to rgba(240,246,252,0.6) (which the SVG inherits via currentColor), so opacity: 0.6 on top of that made it ~0.36 — noticeably darker than the neighbors. On desktop core only dims its ::before glyphs, which our SVG can't inherit, so it does need the fade there.

Fixed by resetting opacity: 1 inside the mobile block so the fade only applies on desktop (a5a5eb2). Verified live at both breakpoints this time — effective color is rgba(240,246,252,0.6) and it blends on mobile and desktop.

Generated by Claude.

dhasilva and others added 2 commits July 10, 2026 16:02

changelog: Forms mobile admin bar fix

8074f6a

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

dhasilva added the [Status] Needs Review This PR is ready for review. label Jul 10, 2026

dhasilva self-assigned this Jul 10, 2026

github-actions Bot added [Feature] Contact Form [Package] Forms labels Jul 10, 2026

dhasilva merged commit 80ed8a5 into trunk Jul 13, 2026
73 of 74 checks passed

dhasilva deleted the fix/dsgcom-595-form-responses-masterbar-mobile branch July 13, 2026 19:43

github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Jul 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: keep Form Responses admin bar link visible on mobile#50421

Forms: keep Form Responses admin bar link visible on mobile#50421
dhasilva merged 5 commits into
trunkfrom
fix/dsgcom-595-form-responses-masterbar-mobile

dhasilva commented Jul 10, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

jp-launch-control Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

CGastrell commented Jul 10, 2026

Uh oh!

dhasilva commented Jul 13, 2026

Uh oh!

dhasilva commented Jul 13, 2026

Uh oh!

dhasilva commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dhasilva commented Jul 10, 2026

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

jp-launch-control Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

CGastrell commented Jul 10, 2026

Uh oh!

dhasilva commented Jul 13, 2026

Uh oh!

dhasilva commented Jul 13, 2026

Uh oh!

dhasilva commented Jul 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jul 10, 2026 •

edited

Loading

jp-launch-control Bot commented Jul 10, 2026 •

edited

Loading